Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test.each type always return a callable function #10488

Merged
merged 9 commits into from
Sep 13, 2020
Merged

fix: test.each type always return a callable function #10488

merged 9 commits into from
Sep 13, 2020

Conversation

scttcper
Copy link
Contributor

@scttcper scttcper commented Sep 8, 2020

Summary

Changes .each type to always return a callable function

Test plan

All documented use cases of .each expect a callable function

related to #9326
fixes #10447

@facebook-github-bot
Copy link
Contributor

Hi @scttcper!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@scttcper scttcper changed the title fix: Remove .each void return type fix: test.each type always return a callable function Sep 10, 2020
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a type test as well, please? Like #10480

@SimenB SimenB merged commit a79c34b into jestjs:master Sep 13, 2020
@SimenB
Copy link
Member

SimenB commented Sep 13, 2020

Thanks @scttcper!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.each is unusable with @jest/globals
3 participants